• rsesek's avatar
    Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive... · db530b15
    rsesek authored
    Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ )
    
    Reason for revert:
    Revert unwarranted.
    
    Original issue's description:
    > Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ )
    >
    > Reason for revert:
    > A significant number of bots are broken after this landed. This is a speculative revert. Please re-land in case this was not the error.
    >
    > Original issue's description:
    > > Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python.
    > >
    > > When comparing large targets like //chrome, it is nearly impossible to deal with
    > > the mountainous 46,000 lines of output the executable script produces. With an
    > > interactive environment, it is much easier to compare differences and drill-down
    > > into specific issues.
    > >
    > > BUG=622889
    > > R=scottmg@chromium.org
    > >
    > > Committed: https://chromium.googlesource.com/chromium/src/+/9f1375ea1bfb9f35e48b69f4c10c8ffa3233ca2a
    >
    > TBR=scottmg@chromium.org,rsesek@chromium.org
    > # Skipping CQ checks because original CL landed less than 1 days ago.
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=622889
    >
    > Committed: https://crrev.com/74af4d66235496370bd173c6139314e8adfecb2e
    > Cr-Commit-Position: refs/heads/master@{#402514}
    
    TBR=scottmg@chromium.org,khushalsagar@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=622889
    
    Review-Url: https://codereview.chromium.org/2110543003
    Cr-Commit-Position: refs/heads/master@{#402533}
    db530b15
gyp_flag_compare.py 14.6 KB