GitLab

This CL changes the OmniboxPopup such as it doesn't need access to the
toolbar view to be presented. Instead it only needs a pointer to its
superview.
The pointer to the view was used to present the popup above or below it
to show the shadow between the omnibox and the popup or not.

This CL changes it by adding the shadow if needed in the popup.

It also removes the white rectangle recovering the place normally
occupied by the toolbar during NTP animation (to avoid seeing the
google logo moving up as the toolbar is hidden). To do that, the
toolbar is directly shown if there are results to be displayed.

Bug: 786940
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6a8dea25702b4644f0f0c76fc34b01c1deaf6a88
Reviewed-on: https://chromium-review.googlesource.com/881182
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531864}