• David Bokan's avatar
    Revert "[Reland#2] Make programmatic scrolls respect smooth scroll flag" · dbef1c60
    David Bokan authored
    This reverts commit b746c948.
    
    Reason for revert: Still failing on Mac web tests: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16983
    
    Original change's description:
    > [Reland#2] Make programmatic scrolls respect smooth scroll flag
    > 
    > Programmatic smooth scrolls should also be instant if the smooth scroll
    > flag is explicitly disabled.
    > 
    > Previously landed in https://crrev.com/c/1536759 and in
    > https://crrev.com/c/2009842
    > 
    > To reland, this CL force enables the scroll animator in Blink web
    > tests. Without this, the usual flow for determining if the animator is
    > enabled is followed, which leads to inconsistencies. On Mac, the
    > animator is enabled in Chrome but not in content shell. This leads to
    > inconsistencies with other platforms (Mac tests ran without smooth
    > scroll while Linux/Windows ran with) and ensuring we test what we ship.
    > 
    > This change required some minor fixes to tests that assumed instant
    > scroll on Mac (and uncovered one real bug).
    > 
    > Second reland fixes a few more tests on Mac. See diff from original
    > patchset for changes.
    > 
    > TBR=flackr@chromium.org,nasko@chromium.org
    > 
    > Bug: 944583
    > Change-Id: Ib91c417f1fcc2b27601f2c7039b02da72b9d5420
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022356
    > Reviewed-by: David Bokan <bokan@chromium.org>
    > Commit-Queue: David Bokan <bokan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#735480}
    
    TBR=flackr@chromium.org,nasko@chromium.org,bokan@chromium.org
    
    Change-Id: Ifad1c0b6a19f222391c2361e80c699d27da7576b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 944583
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024412Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#735704}
    dbef1c60
vertical-scrollbar-in-rtl.html 4.81 KB