• Dale Curtis's avatar
    Revert "Remove kHaveFutureData restriction from play state notifications." · dc5d47c8
    Dale Curtis authored
    This reverts commit b0ec93f6.
    
    Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=812423
    
    Original change's description:
    > Remove kHaveFutureData restriction from play state notifications.
    > 
    > This reland marks media-src-suspend-after-have-future-data and
    > media-src-suspend-after-have-metadata as SlowTest(s) now that they no
    > longer permanently time out. Each takes ~2ish seconds in release build
    > and so meets the criteria for being a SlowTest.
    > 
    > This also changes WMPI to not try and get the current time value prior
    > to the HaveCurrentData state (which Blink already respects).
    > 
    > ========= [ Original Description Follows ] ===============
    > 
    > HTMLMediaElement should tell WebMediaPlayer about play state changes
    > as soon as the kHaveMetaData state is reached.
    > 
    > This will eventually allow us to delete a bunch of guessing-game type
    > code for idle suspension and instead rely on actually getting a play()
    > call from Blink to wake up when needed.
    > 
    > We can't stop WMPI from reaching the future data state quite yet though,
    > because it has implications on the delivery of 'canplay' and 'canplaythrough'
    > events that need to be part of a larger preload=metadata experiment. See old
    > discussion on this here:
    > 
    > https://lists.w3.org/Archives/Public/public-whatwg-archive/2015Jul/0007.html
    > 
    > Note: This change exposed some bugs in how the ready state maximum is used
    > and the states at which a video frame is expected. These issues are fixed
    > in the HTMLVideoElement.
    > 
    > BUG=694855, 756897, 809998
    > TEST=existing suspend tests no longer flake.
    > 
    > Change-Id: Ie6297df474c1f5da56ca6c0e81efa636fbc349bf
    > Reviewed-on: https://chromium-review.googlesource.com/915081
    > Reviewed-by: Frank Liberato <liberato@chromium.org>
    > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    > Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#536487}
    
    TBR=dalecurtis@chromium.org,mlamouri@chromium.org,liberato@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 694855, 756897, 809998
    Change-Id: I176b5116682851853ff2773e6e4a77a9ac2664b2
    Reviewed-on: https://chromium-review.googlesource.com/920481Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
    Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#536988}
    dc5d47c8
SlowTests 34.6 KB