• François Beaufort's avatar
    Reland "[PTZ] Add macOS support" · dcda8c2e
    François Beaufort authored
    This reverts commit 1e32efc6.
    
    Reason for revert:
    Some tests used to fail in WebRTC Chromium Mac Tester bot.
    Since macOS now supports detecting PTZ-capable cameras with this patch,
    it is no longer correct to assume that pan_tilt_zoom_supported() will be
    false for every enumerated camera, so let's remove the test named
    VideoCaptureDeviceFactoryMacTest.ListDevicesWithNoPanTiltZoomSupport
    
    
    Original change's description:
    > Revert "[PTZ] Add macOS support"
    >
    > This reverts commit 6fc7c32c.
    >
    > Reason for revert: crbug.com/1128470
    >
    > Original change's description:
    > > [PTZ] Add macOS support
    > >
    > > This CL makes sure a USB Webcam device on macOS properly advertises its
    > > PTZ support. When supported, the pan, tilt, and zoom controls (ranges
    > > and values) are available to websites that user has granted access to.
    > >
    > > Bug: 934063
    > > Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596
    > > Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
    > > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
    > > Reviewed-by: Avi Drissman <avi@chromium.org>
    > > Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
    > > Cr-Commit-Position: refs/heads/master@{#807387}
    >
    > TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 934063
    > Change-Id: I88b1a41d28f5ad34f149f489b22eae6753e051dd
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418577
    > Reviewed-by: Markus Handell <handellm@google.com>
    > Commit-Queue: Markus Handell <handellm@google.com>
    > Cr-Commit-Position: refs/heads/master@{#808384}
    
    TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org,handellm@google.com
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 934063
    Change-Id: I82b757e1b5d3e6e62f520982ac5e4ef216849550
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420031Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Reviewed-by: default avatarMarkus Handell <handellm@google.com>
    Reviewed-by: default avatarFrançois Beaufort <beaufort.francois@gmail.com>
    Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#809727}
    dcda8c2e
video_capture_device_mac.mm 35.9 KB