• Dominic Farolino's avatar
    Revert "Add referrer DumpWithoutCrash to WebURLLoaderImpl" · dce9f016
    Dominic Farolino authored
    This reverts commit 04dc0257.
    
    Reason for revert: This was a debugging CL to help get information on a DumpWithoutCrash.
    
    Original change's description:
    > Add referrer DumpWithoutCrash to WebURLLoaderImpl
    > 
    > The network service's
    > OnCancelURLRequestWithPolicyViolatingReferrerHeader method is called
    > after it has been determined that a URLRequest's referrer does not match
    > what the policy demands. This method performs a DumpWithoutCrash for
    > debugging. However, this is called within the network service, so the
    > path of the request's creation is not captured in the stack trace,
    > making it less useful.
    > 
    > This CL checks whether or not a request's referrer matches what its
    > policy demands earlier, when a network::ResourceRequest is created by
    > WebURLLoaderImpl. This captures a better picture of a renderer-initiated
    > request's origins in the stack trace, which is much more useful for
    > debugging.
    > 
    > Bug: 1004083
    > Change-Id: I867e488a860e2ac042a1eb93bff04e5f10a3126e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803936
    > Commit-Queue: Dominic Farolino <dom@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#696684}
    
    TBR=yhirano@chromium.org,mmenke@chromium.org,dom@chromium.org
    
    Change-Id: If4759af2fa77deb36fd36a75b0a09f496f06a79f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1004083
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806617Reviewed-by: default avatarDominic Farolino <dom@chromium.org>
    Commit-Queue: Dominic Farolino <dom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#696772}
    dce9f016
web_url_loader_impl.cc 54 KB