GitLab

Null crashes and flakiness test failures have taken place after
converting WebTestHostMsg_InitiateCaptureDump and BlinkTestHostMsg_PrintMessage.

The flakiness happened when a message came from different frames
almost simultaneously. But, existing implementation was implemented by
using Remote instead of AssociatedRemote. So, a race condition happened.

Clusterfuzz has reported crashes that happened in BlinkTestController.
The crashes happened in case of when BlinkTestClientImpl called
functions of BlinkTestController even after BlinkTestController
was destroyed. So, this CL makes BlinkTestController inherit
BlinkTestClient interface directly in order to completely eliminate
the possibility of the crash.

Bug: 1059322, 1059474, 1061180, 1061328, 1061441
Change-Id: Icd499c76e812565e24afd1d7ebf54b82202cf88d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104567
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751622}