GitLab

base::test::ios waiting helpers are deprecated and should be replaced
with testing::WaitUntilConditionOrTimeout, which does not bring the
whole test down with a DCHECK on failure.

This CL migrates the tests in
//ios/chrome/browser/{ui/settings|passwords} directories.

It also adds a new waiting constant kWaitForActionTimeout (10
seconds), which is based on TestTimeouts::action_timeout() (currently
10 seconds). The latter was used as the default argument for the
base::test::ios helpers which did not specify another timeout.

Bug: 784735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I84a528127eb061baefff799f6e467b72d6b1465a
Reviewed-on: https://chromium-review.googlesource.com/774266
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517376}