• Karan Bhatia's avatar
    Revert "[hid] Replicate self-destruct logic in connection fake" · dd4945c9
    Karan Bhatia authored
    This reverts commit 1b26f574.
    
    Reason for revert: Causes HidServiceTest.OpenAndNavigateCrossOrigin
    to fail.
    
    Original change's description:
    > [hid] Replicate self-destruct logic in connection fake
    >
    > HidConnectionImpl is self-owned and will self-destruct on
    > disconnection of the HidConnection or HidConnectionWatcher.
    > This CL modifies the FakeHidConnection used in tests so it
    > behaves the same way.
    >
    > BUG=1126689
    >
    > Change-Id: I8bbdcca7c77699749c6022f01b8a456c4891cdb8
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441151
    > Commit-Queue: Reilly Grant <reillyg@chromium.org>
    > Auto-Submit: Matt Reynolds <mattreynolds@chromium.org>
    > Reviewed-by: Reilly Grant <reillyg@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#812858}
    
    TBR=reillyg@chromium.org,mattreynolds@chromium.org,andypaicu@chromium.org
    
    Change-Id: Ibd1de02feee8d39e071a3291f3dce2062eff3270
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    TBR: mattreynolds@chromium.org
    Bug: 1126689, 1134346
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443760
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#812941}
    dd4945c9
hid_service_unittest.cc 12.6 KB