• Keren Zhu's avatar
    MacViews: Fix Chinese IME dismissal on arrow key bug · dd5a8d89
    Keren Zhu authored
    The Chinese Pinyin IME on Mac uses arrow keys to select candidate words.
    Because -[NSView interpretKeyEvents:] silently consumes the arrow key
    without notifying NSTextInputClient, currently MacViews textfield will
    handle arrow keys as accelerators and dismiss the IME even in the
    presence of composition text.
    
    This CL fixes this bug by omitting arrow keys as accelerators when the
    composition text exists. This bug has the same root cause as seen in
    crbug/883952
    
    Bug: 915924
    Change-Id: I408fbb637e635c2e048a83dfbc1847820019827e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464078
    Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
    Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#816073}
    dd5a8d89
bridged_content_view.mm 53.7 KB