• Hiroki Nakagawa's avatar
    Reland "cros: Implement ClipboardImageModelFactory" · 57af2c42
    Hiroki Nakagawa authored
    This reverts commit 5822a03a.
    
    Reason for revert:
    It turned out that the test is flaky regardless of this change.
    Probably this just made it easier to reproduce the flakiness.
    
    Original change's description:
    > Revert "cros: Implement ClipboardImageModelFactory"
    > 
    > This reverts commit 056d2885.
    > 
    > Reason for revert:
    > This is a speculative revert for failures on 
    > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382
    > 
    > This could fail the following test:
    > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText
    > 
    > Original change's description:
    > > cros: Implement ClipboardImageModelFactory
    > > 
    > > Implements ClipboardImageModelFactoryImpl.
    > > Previous CL landed ClipboardImageModelFactory, and all
    > > ash-side usages of the factory.
    > > 
    > > This CL implements rendering of HTML via
    > > ClipboardImageModelRequest.
    > > 
    > > Bug: 1117230
    > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395
    > > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > > Auto-Submit: Alex Newcomer <newcomer@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#802779}
    > 
    > TBR=xiyuan@chromium.org,newcomer@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 1117230
    > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532
    > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#803003}
    
    TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1117230
    Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#803027}
    57af2c42
clipboard_image_model_request.h 3.53 KB