-
rego@igalia.com authored
According to the spec the ::first-line pseudo-element do not apply to grid containers (neither to flexboxes). Modified RenderBlock::findFirstLetterBlock() to use isRenderBlockFlow() instead of isFlexibleBox(). This change has been already made before in several parts of the code, but there was one missing case here. Fix issue in RenderBlock::updateFirstLetter() that applies to both grids and flexboxes. Basically if the grid's or flexbox's container was defining the ::first-line pseudo-element and the grid or flexbox itself too, the value from the grid or flexbox was being applied to the items. Add the proper check to avoid this. Added two new tests for grid and modified flexbox test to cover the issue explained above. TEST=css3/flexbox/flexbox-ignore-container-firstLetter.html TEST=fast/css-grid-layout/grid-container-ignore-first-letter.html TEST=fast/css-grid-layout/grid-item-first-letter-valid.html BUG=395788 Review URL: https://codereview.chromium.org/440233002 git-svn-id: svn://svn.chromium.org/blink/trunk@180043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
dd8c2a6b
