• lukasza's avatar
    Rename documentState() to getDocumentState(). · de6c362b
    lukasza authored
    The rename is needed to avoid a naming collision after changing from
    Blink to Chromium naming style.  Right now we have a |DocumentState|
    type and a |documentState| accessor method (differing by case of the
    first character); after a naive rename by the rewrite_to_chrome_style
    tool we would end up with |DocumentState| being the name of both the
    type and the accessor method (with both living in the same namespace).
    
    Prepending a "get" prefix to the name of the accessor method is the
    workaround that fits into the guidance on the recommended
    post-Blink-to-Chromium-rename style suggested by esprehn@ in
    https://crbug.com/582312#c17:
    - Getters favor not using "Get", ex. FirstChild()
    - Unless the type name conflicts, in which case you can either rename
      the type if it's easy and makes sense, or add "Get", ex. GetContext().
    
    BUG=582312
    TBR=creis@chromium.org
    
    Review-Url: https://codereview.chromium.org/2569883002
    Cr-Commit-Position: refs/heads/master@{#437995}
    de6c362b
WebHistoryItem.cpp 6.7 KB