• Akihiro Ota's avatar
    kMenuItem valid child of kMenuListOption for PosInSet/SetSize. · df0c4aea
    Akihiro Ota authored
    This change allows kMenuItems to be valid children of kMenuListOption
    elements for PosInSet and SetSize calculations. The motivating example
    for this change was navigating through the app menu in the Chrome
    toolbar using ChromeVox(the menu that contains buttons for new tab,
    history, downloads, bookmarks, dev tools, etc.). ChromeVox would report
    PosInSet and SetSize of 0 for many elements, due to the fact that
    the elements are held within a kMenuListOption, not a kMenu. In the
    PosInSet and SetSize code, we have checks to ensure valid parent-child
    relationships. This is a case that must have been missed in the
    initial implementation.
    
    Change-Id: I8ab6182862cb9a4112d525044046a1e15048fc5e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757467
    Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
    Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#688669}
    df0c4aea
ax_node.cc 25.2 KB