• Kazuki Takise's avatar
    Don't apply bounds change animation to the first bounds change of PIP resize · df6e1cbc
    Kazuki Takise authored
    The current scenario is as follows:
    1. Just before PIP resize, the next animation type is set
       kAnimationAnimated.
    2. If the bounds doesn't change, the next animation type remains
       kAnimationAnimated.
    3. PIP resize is started and window geometry and viewport are sent
       from Android before the first commit of PIP resize.
    4. On the first commit, as the next animation type is set
       kAnimationAnimated, window geometry is applied with animation
       enabled, but viewport is applied immediately, so we observe a
       glitch for one frame.
    
    This CL changes it so that we make sure to set kAnimationNone once
    PIP resize has started.
    
    at the start of resize.
    
    Bug: b/142105182
    Test: Resized PIP window and confirmed I didn't observe a glitch
    Change-Id: Ie61db4fe86891d5d10654d3c44b6dfe6cb7b1730
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850684
    Commit-Queue: Kazuki Takise <takise@chromium.org>
    Auto-Submit: Kazuki Takise <takise@chromium.org>
    Reviewed-by: default avatarEliot Courtney <edcourtney@chromium.org>
    Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#706746}
    df6e1cbc
client_controlled_shell_surface_unittest.cc 82.2 KB