• Justin Carlson's avatar
    Refactor SyncedPrintersManager. · df87d813
    Justin Carlson authored
    This change brings SyncedPrintersManager closer to PrinterDetector
    style interfaces, and aligns function names/styles with the design doc
    for CUPS printers management.  It also removes a bunch of unique_ptr
    wrapping of printers that are passed around, since these are not at
    all performance critical and the unique_ptr stuff hampers readability
    (and leads to subtle bugs when unique_ptrs are both used in a bind and
    passed as a parameter at the same time).
    
    Also convert it to the factory-function pattern while I'm mucking with
    stuff and clean up the header.
    
    
    Bug: 742487
    Change-Id: Ibc9dd0a2f94dad8cb7a1f4adb1897668800311bf
    Reviewed-on: https://chromium-review.googlesource.com/575289Reviewed-by: default avatarSky Malice <skym@chromium.org>
    Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarSean Kau <skau@chromium.org>
    Commit-Queue: Justin Carlson <justincarlson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#488276}
    df87d813
synced_printers_manager.cc 8.96 KB