• Jinsuk Kim's avatar
    Reland "Android: Remove OverlayPanel-based Preview Tab code" · dfa4fead
    Jinsuk Kim authored
    This reverts commit fb7edd8c.
    
    Reason for revert: Not the culprit!
    
    Original change's description:
    > Revert "Android: Remove OverlayPanel-based Preview Tab code"
    > 
    > This reverts commit 928037da.
    > 
    > Reason for revert: Speculative fix for a mysterious crash in
    > Contextual Search when animating the Overlay.  Issue 1050431.
    > 
    > BUG=1050431
    > 
    > Original change's description:
    > > Android: Remove OverlayPanel-based Preview Tab code
    > > 
    > > Now that Preview Tab is working on top of ThinWebView and BottomSheet,
    > > this CL deletes the old implementation that based it on OverlayPanel.
    > > 
    > > Bug: 1043677
    > > Change-Id: Icccc93cca3f09e9ae122b1e0dcb7537331136ac0
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032466
    > > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    > > Reviewed-by: David Trainor <dtrainor@chromium.org>
    > > Reviewed-by: Donn Denman <donnd@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#739094}
    > 
    > TBR=dtrainor@chromium.org,donnd@chromium.org,yusufo@chromium.org,jinsukkim@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 1043677
    > Change-Id: I7c9fa71c3aba77e3e1c8938db8f1b9f7f28a2b22
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049206
    > Reviewed-by: Donn Denman <donnd@chromium.org>
    > Commit-Queue: Donn Denman <donnd@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#740156}
    
    TBR=dtrainor@chromium.org,donnd@chromium.org,yusufo@chromium.org,jinsukkim@chromium.org
    
    Change-Id: Ifbf3c03cc955bd942bfbcbf791cbddac8cf96e70
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1050431, 1043677
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050404Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#740461}
    dfa4fead
BUILD.gn 269 KB