• Torne (Richard Coles)'s avatar
    Remove MonochromeApplication from Trichrome. · dfb31870
    Torne (Richard Coles) authored
    Remove the MonochromeApplication class from TrichromeChrome's manifest
    so that the regular ChromeApplication will be used instead, to avoid
    trying to set up Monochrome-specific things. Update the comment in
    MonochromeApplication to make it clear that it's not used by
    Trichrome and that it must only be used for things that are specific to
    Monochrome being a WebView implementation.
    
    This fixes the startup crash caused by Trichrome attempting to use
    BIND_EXTERNAL_SERVICE for its child processes when the Trichrome
    manifest does not declare the services as external.
    
    Bug: 917417
    Test: install and launch trichrome_chrome_apk
    Change-Id: If857dfb73b75e15c73398779a159ce7bb1ad56cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1474997
    Commit-Queue: Richard Coles <torne@chromium.org>
    Commit-Queue: Andrew Grieve <agrieve@chromium.org>
    Auto-Submit: Richard Coles <torne@chromium.org>
    Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#632722}
    dfb31870
AndroidManifest_trichrome_chrome.xml 825 Bytes