GitLab

The AppService presents itself to the system differently in these
profile configurations, which has resulted in subtle crashes.

This CL configures SystemWebAppManagerBrowserTest with a third gtest
parameter type. It "defaults" to TestProfileType::kRegular and
establishes a way for system apps to neatly specify a set of their
tests that should have coverage for all profile types.

Bespoke tests for the HelpApp are migrated to this setup, and a subset
of pertinent MediaApp tests are parameterised for profiles.

Verified the desired coverage is satisfied by commenting out code
in web_file_tasks.cc that fixed things that have crashed in the past.
E.g. Unconditionally doing `profile = profile->GetOriginalProfile()`
causes 6 of the guest mode tests to crash, and omitting that completely
causes DCHECK(..IsAppServiceAvailableForProfile) to fail for the
incognito tests.

Bug: b/166730281
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I22e7062eab0d4d21329602ec27afba89197e7c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398450Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Reviewed-by: Jiewei Qian  <qjw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807259}