GitLab

- Move "enum SyncInitialState" into the .cc.
- Get rid of many rarely or inconsistently used "using syncer::*"s.
- Update some comments.
- Remove a few unnecessary "virtual"s.
- Merge ChangePreferredDataTypes into OnUserChoseDatatypes - all updates
  must go through that.
  - As a consequence, update SyncAwareCounterTests. In particular, don't
    use syncer::HISTORY_DELETE_DIRECTIVES which is not a user-selectable
    type. Instead use syncer::TYPED_URLS, which corresponds to the
    "History" checkbox, and which implies HISTORY_DELETE_DIRECTIVES.

Bug: 839834
Change-Id: Ifea0178c1f1e1c1546a1f904c1e52d527df9ed7b
Reviewed-on: https://chromium-review.googlesource.com/1106171Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568764}