• Hazem Ashmawy's avatar
    [AW] batch non-embedded services tests · dfc62c87
    Hazem Ashmawy authored
    Here is a per-class breakdown:
    - CrashReceiverServiceTest: batch under UNIT_TESTS, all existing tests
        are unit-tests-like, they don't launch any services or any UI.
    - MetricsBridgeServiceTest: two tests don't actually launch any service
        or UI so they are moved to a separate class and batched as
        UNIT_TESTS, remaining two tests are marked best left unbatched
        because they bind and unbind to a service and depend on having a
        fresh instance of that service every time, restarting the process
        makes sure they start with a clean state.
    - MinidumpUploadJobTest: These tests have n TestRule that launches a
        browser process and loads native library, it's safer to leave them
        unbatched.
    - VariationsSeedServerTest: Tests launches (bind/unbind) to service,
        leaving them unbatched makes sure that the service will be killed
        after each test leaving a clean state.
    - VisualStateCallbackTest: It has only one test that depends on
        multiprocess mode and it should remain unbatched.
    
    Bug: 1120847
    Test: run_webview_instrumentation_test_apk -f "*.android_webview.test.services*"
    Change-Id: I7dbf0d4d5573eb9865f612d1c087627b705c2b19
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440658
    Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
    Commit-Queue: Changwan Ryu <changwan@chromium.org>
    Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
    Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#813781}
    dfc62c87
BUILD.gn 26.1 KB