• Lukasz Anforowicz's avatar
    Explicitly pass |is_for_isolated_world| to URLLoaderFactoryManager. · e00adef9
    Lukasz Anforowicz authored
    Before this CL, extensions::URLLoaderFactoryManager's
    OverrideURLLoaderFactoryParams method would not be explicitly told
    whether the factory will be used by a content script.  Instead, the
    method would try to infer this, by checking if the |process| where the
    factory will be used is an extension process.
    
    The inference above will give incorrect results in case of content
    scripts being injected into (other) extensions - in this case the
    |process|-based inference will incorrectly conclude that the factory is
    *not* for a content script.
    
    After this CL, an explicit |is_for_isolated_world| parameter is passed
    to the OverrideURLLoaderFactoryParams method.
    
    Bug: 1025303
    Change-Id: If947796f6017ddbe2dd6968254cb8b9ea7f34c94
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920004
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
    Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#722673}
    e00adef9
url_loader_factory_manager.h 5.42 KB