• Nate Fischer's avatar
    AW: implement setCookie for the network service · e040790c
    Nate Fischer authored
    This implements CookieManager#setCookie for the network service code
    path, plumbing SetCanonicalCookie through AwCookieManagerWrapper.
    
    Along with this change, this re-implements #setCookie for the legacy
    code path, to use SetCanonicalCookieAsync instead of
    SetCookieWithOptionsAsync (to share code between the new and old code
    paths).
    
    This splits apart a test, which I found to be useful when debugging
    (since the "good URL" and "bad URL" case are actually quite different).
    
    This removes a bunch of tests from the test filter, and adds in new
    breakages (mainly due to #hasCookies() not being implemented yet).
    
    This also updates some TODOs, to point at finer-grained crbugs I've
    filed since the last CL.
    
    Bug: 933460, 931641, 902641, 933462, 893580
    Test: run_webview_instrumentation_test_apk -f=CookieManagerTest#* \
    Test: --enable-features=NetworkService,NetworkServiceInProcess
    Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
    Change-Id: I3f29a209aa9a442d273b8673c01848801f298ee8
    Reviewed-on: https://chromium-review.googlesource.com/c/1478470Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
    Reviewed-by: default avatarRichard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#634460}
    e040790c
cookie_manager.h 5.53 KB