• Matt Giuca's avatar
    Web Share Target (desktop): Fail gracefully if manifest URL is blank. · e0739ed0
    Matt Giuca authored
    Previously it would DCHECK if any share target in the Preferences file
    had a blank or invalid manifest URL, which could be caused if the share
    target was previously installed using an app banner. Since this is
    corrupted user data, we should recover, not DCHECK, in these cases.
    
    Also adds a DCHECK to catch cases that would write this corrupted data
    into the preferences. This doesn't yet fix the issue, but it does report
    it to developers. The DCHECK only fires if the manifest has a
    share_target and the --enable-experimental-web-platform-features flag is
    enabled (so it won't be too annoying).
    
    Bug: 762388
    Change-Id: Ibd800dc529510d4755068f7bb0c55f8ca083bc7e
    Reviewed-on: https://chromium-review.googlesource.com/652011
    Commit-Queue: Matt Giuca <mgiuca@chromium.org>
    Reviewed-by: default avatarSam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#504325}
    e0739ed0
share_target_pref_helper.cc 1.86 KB