• Cathy Li's avatar
    Reland "[Feed V2] Update margins to render the external surface cards correctly." · e09082e4
    Cathy Li authored
    This reverts commit ac85bf58.
    
    Reason for revert: We are going back to client-side change for margins, since server-side margin fix does not get the full UX we need.
    
    Original change's description:
    > Revert "[Feed V2] Update margins to render the external surface cards correctly."
    > 
    > This reverts commit d6d62019.
    > 
    > Reason for revert: We want to keep control over the margins from the Chrome side.
    > 
    > Original change's description:
    > > [Feed V2] Update margins to render the external surface cards correctly.
    > > 
    > > Bug: 1106425, b/161142289
    > > Change-Id: If3c89644289b6eb1d5b61f6680f03bf95e3b6888
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303172
    > > Reviewed-by: David Trainor <dtrainor@chromium.org>
    > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    > > Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#789547}
    > 
    > TBR=dewittj@chromium.org,dtrainor@chromium.org,carlosk@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 1106425
    > Bug: b/161142289
    > Change-Id: I5b01fbb8167caaa027a9d7423c1272d66c35a56b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347220
    > Reviewed-by: Cathy Li <chili@chromium.org>
    > Reviewed-by: David Trainor <dtrainor@chromium.org>
    > Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    > Commit-Queue: Cathy Li <chili@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#797373}
    
    TBR=dewittj@chromium.org,dtrainor@chromium.org,carlosk@chromium.org,chili@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1106425
    Bug: b/161142289
    Change-Id: If95f91faa9511f8eb83f73680d92814422433377
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363005Reviewed-by: default avatarCathy Li <chili@chromium.org>
    Reviewed-by: default avatarCarlos Knippschild <carlosk@chromium.org>
    Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
    Commit-Queue: Cathy Li <chili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#800037}
    e09082e4
dimens.xml 30.6 KB