• Alex Danilo's avatar
    Revert "Files app: Force focus out of <body>" · e0c414fe
    Alex Danilo authored
    This reverts commit 2bbea72b.
    
    Reason for revert: caused regression shown in crbug.com/1060527
    
    Original change's description:
    > Files app: Force focus out of <body>
    >
    > When the element has the focus is hidden/removed/disabled the browser
    > moves the focus to <body>, in this situation user doesn't have any
    > visual clue where is the focus. To fix this we move the focus from
    > <body> to file list which is the default element when opening Files app.
    >
    > Use "focusin" and "focusout" in the <body> element, because these two
    > events bubble from any body's child element, whereas "focus" event
    > doesn't. In the event handler we use requestIdleCallback() to give a
    > chance for any synchronous code to finish and potentially set the focus
    > somewhere else other than <body>.
    >
    > Test: browser_tests --gtest_filter="*tabindexFocusBody*"
    > Bug: 1059137,957413
    > Change-Id: I9563294a3b6c541cf6bd2bba03470041bc8af41b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089444
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Alex Danilo <adanilo@chromium.org>
    > Commit-Queue: Noel Gordon <noel@chromium.org>
    > Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#748090}
    
    TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1059137, 957413, 1060527
    Change-Id: I52e68555b814172d532202631269c676ec9c15ad
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100050
    Commit-Queue: Alex Danilo <adanilo@chromium.org>
    Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
    Reviewed-by: default avatarAlex Danilo <adanilo@chromium.org>
    Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#749550}
    e0c414fe
file_manager_browsertest.cc 41.7 KB