• James Cook's avatar
    chromeos: Sync APP_LIST when Chrome app or ARC app sync is enabled · e161f8e7
    James Cook authored
    The SplitSettingsSync feature makes it possible to independently
    sync Chrome apps (via browser sync) and ARC apps (via OS sync).
    The app list data model and UI code can handle references to
    missing apps (for example, on Chromebooks that don't support ARC++
    the app list data model may have references to ARC++ apps from
    sync, but the UI gracefully hides them).
    
    I initially tied the APP_LIST data type to OS apps. However, the
    user can end up in an odd state if we sync Chrome apps
    without syncing the app list metadata. For example, a user could
    disable OS sync, enable browser sync, install some Chrome
    apps, move them around in the app list, set up a new Chromebook,
    then discover that the apps are in the wrong order or are not
    pinned to the shelf.
    
    Ensure we sync the metadata if either browser apps or OS apps are
    being synced.
    
    Bug: 1013466
    Test: added to sync_integration_tests
    
    Change-Id: Iddc13a978bb84259fadf91fe5fd9454606ba650d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931098
    Commit-Queue: James Cook <jamescook@chromium.org>
    Reviewed-by: default avatarMarc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#720582}
    e161f8e7
sync_user_settings_impl.cc 9.32 KB