• Yao Xiao's avatar
    [floc] Remove the EventTrigger field in the FlocIdComputed event · e16309d9
    Yao Xiao authored
    Why: That field is never used & not useful for the server side analysis.
    
    This CL also removes a workaround that disables the initial floc
    loggings when permission disallows
    (in FlocIdProviderImpl::LogFlocComputedEvent). We had this workaround
    because otherwise the logging would mess up with the user event
    expectations in SingleClientUserEventsSyncTest, but that workaround is
    not ideal. This CL fixes it by disabling kFlocIdComputedEventLogging for
    the test suite, and adds a new test for the enabled case. The impact
    of this fix is it will cause additional events to be logged.
    
    
    Bug: 1148358
    Change-Id: I70cef531b89b434b5572b419acc8dd2412888498
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572733Reviewed-by: default avatarJosh Karlin <jkarlin@chromium.org>
    Reviewed-by: default avatarMarc Treib <treib@chromium.org>
    Commit-Queue: Yao Xiao <yaoxia@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#835468}
    e16309d9
floc_id_provider_browsertest.cc 27.6 KB