• Joshua Pawlicki's avatar
    Revert "[arraybuffer] Switch backing store from DataHandle to v8::BackingStore" · e1a7611d
    Joshua Pawlicki authored
    This reverts commit b0985684.
    
    Reason for revert: Speculative revert. Suspect this is causing renderer crashes for
    
    webaudio/AudioBuffer/huge-buffer.html
    webaudio/dom-exceptions.html
    
    https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/58083
    
    Original change's description:
    > [arraybuffer] Switch backing store from DataHandle to v8::BackingStore
    > 
    > With this CL we finally use v8::BackingStore as the backing store
    > implementation of blink::ArrayBuffer.
    > 
    > Changes:
    > * Use v8::BackingStore as the backing store for ArrayBufferContents.
    > * Remove ArraybufferContents::DataHolder and
    >   ArrayBufferContents::DataHandle.
    > * Replace all uses of DataHolder in ArraybufferContents with uses of
    >   v8::BackingStore.
    > * Replace the use of DataHandle in the V8 bindings.
    > * Add an exception to the presubmit check to allow std::shared_ptr in
    >   ArrayBufferContents. It is contained there and does not escape.
    > 
    > R=​haraken@chromium.org, ulan@chromium.org
    > 
    > Bug: chromium:1008840
    > Change-Id: Iffa31e889daf4ae54de96f55b4612833d096a884
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886858
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#712571}
    
    TBR=ulan@chromium.org,haraken@chromium.org,agrieve@chromium.org,ahaas@chromium.org
    
    Change-Id: I88668a9d2d582ef38ccb82f1c87139da4c74db62
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1008840
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899413Reviewed-by: default avatarJoshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#712620}
    e1a7611d
interface.cc.tmpl 49.8 KB