• pasko's avatar
    Revert "Intercept base::File Open/Close" · e1ceecf5
    pasko authored
    This reverts commit 45a0dc0b.
    > Intercept base::File Open/Close
    >
    > When a file descriptor is opened by the base::File, all calls to close(3) from
    > the same dynamic library will hit a CHECK unless they are made from a
    > whitelist of callsites belonging to base::File.
    >
    > There is a handy protect_file_posix.gypi introduced to make it easy to enable
    > on Chrome-for-Android.
    >
    > This 'linker magic' is somewhat crazy, so:
    > 1. it will be *removed *when crbug.com/424562 is fixed
    > 2. it should only be used by a whitelist of binaries/libraries (in the
    >    opensource part: libchromeshell only)
    >
    > BUG=424562
    >
    > Review URL: https://codereview.chromium.org/676873004
    >
    > Cr-Commit-Position: refs/heads/master@{#304592}
    
    Reason: crashes are not numerous, not much sense to fix, some explanations found
    elsewhere.
    
    BUG=424562
    
    Review URL: https://codereview.chromium.org/1101723004
    
    Cr-Commit-Position: refs/heads/master@{#327051}
    e1ceecf5
file_posix.cc 14.7 KB