• Devlin's avatar
    Revert "Reland "base: Add API to restrict thread affinity to little cores on Android"" · e2005576
    Devlin authored
    This reverts commit 50136be2.
    
    Reason for revert:
    
    This also fails consistently on Linux Trusty:
    
    https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/14445
    
    Sample failure:
    
    [ RUN      ] CpuAffinityTest.SetThreadCpuAffinityMode
    ../../base/cpu_affinity_posix_unittest.cc:114: Failure
    Value of: SetThreadCpuAffinityMode(thread_id, CpuAffinityMode::kLittleCoresOnly)
      Actual: false
    Expected: true
    Stack trace:
    #0 0x55b884c793f3 base::CpuAffinityTest_SetThreadCpuAffinityMode_Test::TestBody()
    
    ../../base/cpu_affinity_posix_unittest.cc:119: Failure
    Value of: SetThreadCpuAffinityMode(thread_id, CpuAffinityMode::kDefault)
      Actual: false
    Expected: true
    Stack trace:
    #0 0x55b884c797da base::CpuAffinityTest_SetThreadCpuAffinityMode_Test::TestBody()
    
    Original change's description:
    > Reland "base: Add API to restrict thread affinity to little cores on Android"
    > 
    > This is a reland of 027aa92e
    > 
    > Relanding but disabling test on CrOS devices (some of our CrOS devices
    > seem to have asymmetric CPUs that aren't covered by the test).
    > 
    > Original change's description:
    > > base: Add API to restrict thread affinity to little cores on Android
    > >
    > > Adds functions that facilitate setting the CPU affinity of a given
    > > thread or process to all little cores on the system.
    > >
    > > We intend to use this API to run a power experiment.
    > >
    > > Bug: 1111789
    > > Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176
    > > Commit-Queue: Eric Seckler <eseckler@chromium.org>
    > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#794998}
    > 
    > TBR: dcheng@chromium.org
    > Bug: 1111789
    > Change-Id: I59315ec0e9a1727986278a04fa5bde409143dfb5
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339416
    > Reviewed-by: Eric Seckler <eseckler@chromium.org>
    > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > Auto-Submit: Eric Seckler <eseckler@chromium.org>
    > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
    > Commit-Queue: Eric Seckler <eseckler@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#795126}
    
    TBR=dcheng@chromium.org,skyostil@chromium.org,eseckler@chromium.org
    
    Change-Id: I3be932b56d8b42e10a7179e5310d041c1b687c28
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1111789
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339395Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#795203}
    e2005576
process_metrics_linux.cc 35.1 KB