• Andreea Costinas's avatar
    arc/net: replace ARC proxy bypass list delimiter · e252934f
    Andreea Costinas authored
    Chrome forwards the proxy exception bypass list as a string with host names
    delimited by semicolon [;] while ARC expects a colon [,] delimiter. This
    causes loss of network conectivity in ARC.
    
    This CL formats the proxy bypass list sent to ARC by replacing delimiters
    and removing the rendundant delimiter at the end of the string bypass list.
    
      1. setup an Ethernet proxy connection with no bypass list
      2. verified ARC and ARC app have network connectivity
      3. added one host in the bypass list
      4. verified ARC connectivity is lost
      5. deployed Chrome with fix on the device
      6. verified ARC has network connectivity
      7. verified app on ARC respects proxy and proxy bypass item
      8. added three host names in the bypass list
      9. verified ARC app respects bypass list for all hostnames
    
    Bug: b:133193788
    Change-Id: I363879fe886e3c7abc6557ef163b0d930398b7d7
    Tests: manually tested with following steps
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630481Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Reviewed-by: default avatarAsanka Herath <asanka@chromium.org>
    Reviewed-by: default avatarPavol Marko <pmarko@chromium.org>
    Commit-Queue: Pavol Marko <pmarko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#664960}
    e252934f
proxy_bypass_rules.cc 14.5 KB