• Tonko Sabolčec's avatar
    Revert "[OSCrypt] Add feature for preventing key overwrites in Keychain on Mac" · e27be9d1
    Tonko Sabolčec authored
    This reverts commit 3ca917bd.
    
    Reason for revert: The CL caused crashes on Chrome canary on Mac: crbug.com/882787
    
    Original change's description:
    > [OSCrypt] Add feature for preventing key overwrites in Keychain on Mac
    >
    > This Cl includes:
    > - Add a feature flag which is disabled by default.
    > - Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword().
    > - Add tests for the above changes.
    > - Register the local state early from the main thread in os_crypt.
    >
    > Bug: 791541
    > Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe
    > Reviewed-on: https://chromium-review.googlesource.com/1188318
    > Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
    > Reviewed-by: Christos Froussios <cfroussios@chromium.org>
    > Reviewed-by: Dominic Battré <battre@chromium.org>
    > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#589898}
    
    TBR=battre@chromium.org,vasilii@chromium.org,rsesek@chromium.org,cfroussios@chromium.org,tsabolcec@google.com
    
    Change-Id: I1be5c8294985e81115a8856f4105fbff8a3a28a9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 791541
    Reviewed-on: https://chromium-review.googlesource.com/1219086Reviewed-by: default avatarChristos Froussios <cfroussios@chromium.org>
    Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
    Cr-Commit-Position: refs/heads/master@{#590270}
    e27be9d1
BUILD.gn 4.93 KB