• Michael Giuffrida's avatar
    ShellTestBaseAura for AppShell unit tests · e2b0ee57
    Michael Giuffrida authored
    ShellTestBaseAura augments extensions::ExtensionsTest and also sets up
    the Aura environment. app_shell_unittests test classes can derive from
    ShellTestBaseAura to get this set-up for free, instead of deriving from
    either ExtensionsTest (which doesn't create a
    ShellExtensionsBrowserClient) or AuraTestBase (which sets up its own
    Screen and RootWindow).
    
    In particular, deriving ShellDesktopControllerAuraTest from AuraTestBase
    doesn't make sense because the ShellDesktopControllerAura creates
    its own screen and RootWindow.
    
    This also provides ShellTestHelperAura, which can be used as a class
    member to get shell environment set-up without deriving a test from
    ExtensionsTest.
    
    Change-Id: I4565c985c77444ebc7325fd7d5295d028f85f774
    Reviewed-on: https://chromium-review.googlesource.com/591641
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarBen Wells <benwells@chromium.org>
    Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#491934}
    e2b0ee57
shell_test_extensions_browser_client.cc 926 Bytes