-
Jenny Zhang authored
This cl adds the following: 1. A new API GetSystemInformation in crosapi::LacrosChromeService to gather Lacros system information which is called from ash. 2. A new SystemLogsSource LacrosSystemLogRemoteSource to fetch Lacros system log data. The unified feedback report will include the additional lacros system information data, and each log entry key with be prefixed with "Lacros ", so that it can be differentiate from the ash system information log entries. The unified feedback will include additional lacros log data such as crash report ids, extensions, memory usage, etc, in system_logs.zip of the feedback report. TEST: 1. Open Lacros chrome, file a feedback from "Help/Report an issue" menu, send a feedback report. Find the report on listnr, download system_logs.zip and check the content. In addition to ash log data, it should include: Lacros CHROME VERSION Lacros OS VERSION Lacros about_sync_data Lacros crash_report_ids Lacros data_reduction_proxy Lacros extensions lacros mem_usgae Lacros mem_usage_with_title Also, clicking on "system and app information" link on feedback dialog, it will show all system log data in a preview UI, which should also display the above Larcros log entries along with ash log entries. 2. File a feedback report from ash chrome, make sure there is a Lacros chrome running. It should send a unified feedback report which includes the additional Lacros system information as shown in Test #1. Bug: 1119925 Change-Id: Ied42b2674dbb68bfed39d119bb7e70e2a177c762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465090Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817579}
aa67f653