• danakj's avatar
    Avoid trying to GetThreatDOMDetails on a non-existent RenderFrame. · e324bd69
    danakj authored
    When ThreatDetails starts up, it walks the frame tree to request the
    DOM details of each frame. However it also tries to request this from
    a RenderFrameHost that has not loaded and created a RenderFrame in a
    renderer process. Previously, this message would be held and eventually
    dropped when the RenderFrameHost is replaced in the commit of the safe
    browsing error page. Soon we will crash if we try to talk to a non-
    existent RenderFrame, so we avoid attempting to do so here.
    
    R=nparker@chromium.org
    
    Bug: 1158869
    Change-Id: I394a3e1775761ec0e99cc63e7f8b3e2d194c4d73
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626177Reviewed-by: default avatarNathan Parker <nparker@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#843569}
    e324bd69
threat_details.cc 34.8 KB