GitLab

The callback passed to SendFeedback is semantically meant to be called
only once (to signify the completion of SendFeedback). However, because
the feedback report depends on multiple conditions completing, this
callback is currently copied into multiple BlobReader callbacks and
invoked only once all have been completed.

This CL replaces the copies by storing the callback in a member and
having the CompleteSendFeedback method call that instead of copying it
around with various bound callback. This allows us to make it a
OnceCallback, improving readability and safety.

We also notice that SendSysLogFeedback, the only function in
feedback_util_chromeos.{h|cc}, is never used. Thus, we can remove these
files entirely.

Bug: 1152268
Change-Id: Ie6d3683562f0374833a83468fc48e98ec0158c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601225Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839760}