• Yutaka Hirano's avatar
    Revert "WebApp: Call RegistryOpenedCallback asynchronously." · e394070d
    Yutaka Hirano authored
    This reverts commit 945fcd73.
    
    Reason for revert: Speculative revert for AppControllerPlatformAppBrowserTest.ActivationFocusesBrowserWindow failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/50628
    
    
    Original change's description:
    > WebApp: Call RegistryOpenedCallback asynchronously.
    > 
    > We should break down this synchronous call chain:
    > 
    > web_app::WebAppSyncBridge::CommitUpdate()
    > web_app::ScopedRegistryUpdate::~ScopedRegistryUpdate()
    > web_app::WebAppInstallFinalizer::UninstallWebApp()
    > web_app::WebAppInstallFinalizer::UninstallWebAppOrRemoveSource()
    > web_app::WebAppInstallFinalizer::UninstallExternalWebApp()
    > web_app::InstallFinalizer::UninstallExternalWebAppByUrl()
    > web_app::PendingAppManagerImpl::UninstallApps()
    > web_app::PendingAppManager::SynchronizeInstalledApps()
    > web_app::ExternalWebAppManager::OnScanForExternalWebApps()
    > web_app::ExternalWebAppManager::ScanForExternalWebApps()
    > web_app::ExternalWebAppManager::Start()
    > web_app::WebAppProvider::OnRegistryControllerReady()
    > web_app::WebAppSyncBridge::OnDatabaseOpened()
    > web_app::WebAppDatabase::OnAllMetadataRead()
    > syncer::ModelTypeStoreImpl::ReadAllMetadataDone()
    > 
    > WebAppSyncBridge::OnDatabaseOpened() must not cause immediate
    > WebAppSyncBridge::CommitUpdate() on same `this`.
    > 
    > Bug: 1084939
    > Change-Id: Ib32c52780a647a0985418c0f92985f041869f104
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212236
    > Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
    > Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#771473}
    
    TBR=ericwilligers@chromium.org,loyso@chromium.org
    
    Change-Id: I80600ec60e1f669ca0823caf77ce36a3985d9dbe
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1084939
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213648Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#771485}
    e394070d
web_app_sync_bridge.cc 18.9 KB