• Jiawei Li's avatar
    [chromecast] Notify page is loading on ReadyToCommitNavigation · e40eb0c5
    Jiawei Li authored
    In certain cases, second DidStartNavigation event will occur prior to
    prior navigation's DidFinishLoad, leading to that CastWebContentsImpl
    would drop second main frame loading event.
    
    DidStartNavigation -> DidStartNavigation -> DidFinishLoad ->
    DidFinishLoad. (LOADING->ignore same LOADING -> LOADED -> IGNORE SAME
    LOADED event). Ignored event won't be broadcasted to
    CastWebContents::Observer. BindingsManagerCast might not work as
    intended under this specific circumstance.
    
    To resolve that, another page loading notification should be added on
    ReadyToCommitNavigation.
    
    Bug: Internal b/149898650
    Test: Verified with manually build.
    Change-Id: Ie119b21495fde6db7b4dd24515ceac3a080c5166
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067870Reviewed-by: default avatarSean Topping <seantopping@chromium.org>
    Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
    Commit-Queue: Jiawei Li <lijiawei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#744058}
    e40eb0c5
cast_web_contents_impl.cc 33.8 KB