• Sam Goto's avatar
    [webid] Prompt the user for permission before loading .well-known/webid · e46cab8b
    Sam Goto authored
    The .well-known/webid file can take an arbitrarily long time to load,
    but even when it loads immediately, it introduces an unnecessarily long
    delay between invoking the API and the browser UX responding to it.
    
    It is the case that the .well-known/webid file can be done
    uncredentialed, and hence in parallel, but for the sake of simplicity
    I'm just changing some of the sequencing of events.
    
    Upon acknowledgement of the permission prompt, we should also open the
    modal dialog right away, before if finishes loading the signin_url,
    because that can also take an arbitrarily long time to load and we want
    to make sure the user understands who is accountable for the delay (i.e.
    that the browser UX has responded to the gesture that the user made)
    
    Bug: 1141125
    Change-Id: I40fc02c03488d3a1d6de383b5397baf4cc7aa604
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631451
    Auto-Submit: Sam Goto <goto@chromium.org>
    Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
    Commit-Queue: Sam Goto <goto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#845859}
    e46cab8b
federated_auth_request_impl.cc 13.1 KB