• Dana Fried's avatar
    Reland "Make PWA titlebar and icons flex and animate properly." · e490a00a
    Dana Fried authored
    This reverts commit de7cd485.
    
    Reason for revert: Fixing issue with Mac tests.
    
    Original change's description:
    > Revert "Make PWA titlebar and icons flex and animate properly."
    > 
    > This reverts commit 8f2f4243.
    > 
    > Reason for revert: speculative revert for test failures on Mac
    > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g.
    > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700
    > 
    > Original change's description:
    > > Make PWA titlebar and icons flex and animate properly.
    > > 
    > > Nested layouts now allocate available space properly to their
    > > descendents. Also, we consistently use flex layout in the PWA titlebar.
    > > 
    > > Removed a couple of invalid assumptions that were encoded as DCHECKs.
    > > 
    > > There are still some inkdrop issues but they are purely cosmetic, see
    > > crbug.com/1006162 for more detail.
    > > 
    > > Bug: 1048061
    > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264
    > > Commit-Queue: Dana Fried <dfried@chromium.org>
    > > Reviewed-by: Peter Boström <pbos@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#738874}
    > 
    > TBR=pbos@chromium.org,dfried@chromium.org
    > 
    > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1048061
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615
    > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#738907}
    
    TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org
    
    Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1048061
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326Reviewed-by: default avatarDana Fried <dfried@chromium.org>
    Commit-Queue: Dana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#742203}
    e490a00a
fill_layout.cc 3.22 KB