• Darren Shen's avatar
    [VK] Fix DisableOverscrollForImeWindow to use overscrolling. · e506d0be
    Darren Shen authored
    VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow tests that
    we don't reduce the viewport size of IME related windows (like the
    floating candidate window when you gesture type). However, the test
    uses ShowKeyboard(true), which shows the locked keyboard. When the
    locked keyboard appears, we don't overscroll. Rather, we reduce the
    size of the work area, shrinking the actual size of the window. The
    test still passes because shrinking the work area also shrinks the
    viewport size.
    
    This patch changes the test to use ShowKeyboard(false), which triggers
    overscrolling. This matches the original intent of the test more
    closely.
    
    TBR=yhanada@chromium.org
    
    Bug: 849995
    Change-Id: Ifdbea75c5b84081fc67cd29e3af21f1984b4a4eb
    Reviewed-on: https://chromium-review.googlesource.com/1160064Reviewed-by: default avatarDarren Shen <shend@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580461}
    e506d0be
keyboard_controller_browsertest.cc 12.2 KB