• Mike Jackson's avatar
    Reland Update axe-core to v3.3.2 · e52df5fc
    Mike Jackson authored
    This change updates the version of axe-core to the latest released
    version. As part of picking up the latest version, the following
    additional changes were made:
    
    1) axe-core removed the 'href-no-hash' rule, so that been removed
       from the test list.
    
    2) Several 'link-in-text-block' tests started failing with
       axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but
       are disabled as part of this change.
         - CrManagementA11yTest.SimpleTest_link_in_text_block
         - CrManagementA11yTestWithExtension.
                                    ExtensionSection_link_in_text_block
         - CrostiniAccessibilityTest.CROSTINI_link_in_text_block
         - CrExtensionsA11yTest.NoExtensions_link_in_text_block
         - MultideviceA11yTest.MULTIDEVICE_link_in_text_block
         - MultideviceFeaturesA11yTest.
                  MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block
    
    3) One 'heading-order' test started failing in v3.0.0 (and later).
       This tests does pass in V2.4.2, but is disabled as part of this
       change.
         - CrExtensionsA11yTestWithMultipleExensions.
                                           WithExtensions_heading_order
    
    4) One color-contrast test started failing. This test has been disabled
       since there other tests also disabled for this rule
         - WelcomeA11y.WelcomeFlow_color_contrast
    
    5) Several DevTools a11y tests were failing. This change either
       updates the baseline or excludes the rule depending upon the
       test/rule itself.
         - http/tests/devtools/a11y-axe-core/basic-a11y-test.js
         - http/tests/devtools/a11y-axe-core/console-a11y-test.js
         - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js
         - http/tests/devtools/a11y-axe-core/performance/performance-pane-a11y-test.js
         - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js
    
    I spent some time investigating the test failures, and it looks
    like axe-core is highlighting legitimate product issues.
    
    Bug: 984817
    Change-Id: I245af601c4f086d96768fa5677e253095fc53087
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841834
    Commit-Queue: Mike Jackson <mjackson@microsoft.com>
    Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: default avatarLorne Mitchell <lomitch@microsoft.com>
    Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#704624}
    e52df5fc
README.chromium 665 Bytes