GitLab

ShouldApplyDimming was skipped in clamshell mode; instead overview
itself would set opacity filter. This patch enables ShouldApplyDimming
(now ShouldApplyColorFilter) for overview clamshell mode and mixes the
shield layer color, which has opacity built in for both tablet and
clamshell mode to match new spec.

I also noticed we always blend with kDarken. So on real dark wallpapers,
light mode black text will still be an issue. But I did notify UX and
I think that is an overall wallpaper issue.

With this change, WallpaperProperty opacity is now always 1.f, so we
can remove WallpaperProperty in a follow up as it only contains blur
now.

Test: manual
Bug: 1145342
Change-Id: Iea321602f577aa848722c6bb665a3de49aff129f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521852
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825117}