• Hazem Ashmawy's avatar
    Reland "[AW][Dev-UI] Reland "Add some espresso tests for flag UI"" · e62cb7e3
    Hazem Ashmawy authored
    This is a reland of db9be6c9
    
    The recent flakes are most probably caused by using of UIAutomator APIs
    to test the developer UI service notification and pressing home button
    in the tearDown of tests. This reland the CL after removing all
    UIAutomator code including the test for persistent notification. A
    separate reland of that test would be done later.
    
    Original change's description:
    > [AW][Dev-UI] Reland "Add some espresso tests for flag UI"
    >
    > This relands https://crbug.com/c/2438534 with a couple small changes:
    >
    > - android:windowSoftInputMode="adjustPan" attribute was missing in the
    >   test manifest but is used in prod manifest. Adding it to the tests
    >   manifest fixes the problem of auto-showing the keyboard on M devices
    >   which was causing the test flakiness. When the keyboard shows up it
    >   hides the view causing espresso to fail.
    >
    > - Merge the small change from https://crrev.com/c/2455687 to
    >   test whether the overrideFlagsMap has the correct entries.
    >
    > Fixed: 1135839, 1130599
    > Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" on android M emulator
    > Change-Id: I973e8cd2b7a9c12651d7a6e14f11a368f6e06bad
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453564
    > Reviewed-by: Changwan Ryu <changwan@chromium.org>
    > Reviewed-by: Nate Fischer <ntfschr@chromium.org>
    > Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#817184}
    
    Change-Id: I9089d7e8d9b61b46b412061715abbf981da03706
    Bug: 1130599, 1135839
    Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" --num_retries=0 --repeat=1000 --break-on-failure
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482142Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
    Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
    Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#818858}
    e62cb7e3
AndroidManifest.xml 9.43 KB