-
Mitsuru Oshima authored
This reverts commit 20aca0dd. Reason for revert: The issue has been resoved in crrev.com/c/2384070 Original change's description: > Revert "Chrome OS: Use layer animation browser window frame activation animation." > > This reverts commit 3a2299e5. > > Reason for revert: Suspected breaking https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38374 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20193 > > Original change's description: > > Chrome OS: Use layer animation browser window frame activation animation. > > > > This is a revised version of original attempt crrev.comc/c/2166804. > > Instead of creating a new layers, this clone and animate the window's layer, > > but makes sure that the animating layer is at the bottom of other layers > > within the window. > > > > * It adds a invisible view with a layer > > at the bottom of the non_client_view (no frame w/o this, so we can exclude such case). > > * Adds the animating layer as a child of this view, with > > "SetMasksToBounds(false)" so that it will not be clipped during animation. > > * Once animation is done, this animating, old layer will be removed. > > > > Bug: 1073685 > > Test: covered by unittests. > > Change-Id: Ib5ae6a218d200394c54932e5b559217fcc7f89e1 > > Fixed: 2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375686 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#802386} > > TBR=sky@chromium.org,oshima@chromium.org > > Change-Id: I10600b9bc69818257f66fb5c1ae86f7fd1119c75 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1073685 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381217 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802539} TBR=sky@chromium.org,oshima@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1073685 Change-Id: I38725fa15f79576db154db91f7ca384578f545b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385815Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#803143}
e6713881
