GitLab

ExtensionInstallPrompt started out life as a prompt to install an
extension, but has since grown into a franken-prompt used for many
different pieces of extension functionality. This leads to technical
debt and complexity, hard-to-reason about code, excessive redirection,
etc, and a number of bugs have been filed about trying to simplify it
(e.g. crbug.com/567839).

Add a comment in ExtensionInstallPrompt discouraging the addition of any
new types that don't actually prompt to install an extension. New code
that needs a dialog should implement a new dialog, rather than piggy-
backing on this class.

Bug: None
Change-Id: I00476b3d4cda8efbbe2b7cf4ae3c39935f004402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075083Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744806}