• Takashi Sakamoto's avatar
    Revert "[Fuchsia] Handle VULKAN feature flag in WebEngine" · e6aed4a9
    Takashi Sakamoto authored
    This reverts commit 74c69a75.
    
    Reason for revert: causing first build failure on Deterministic Fuchsia (dbg).
    
    Sample build: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Fuchsia%20%28dbg%29/561
    
    Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8903731569632286240/+/steps/First_build/0/stdout?format=raw
    
    [47036/47333] SOLINK ./lib/libweb_engine_core.so
    ...
    ld.lld: error: undefined symbol: switches::kEnableFeatures
    >>> referenced by context_provider_impl.cc:208 (../../fuchsia/engine/context_provider_impl.cc:208)
    >>>               obj/fuchsia/engine/web_engine_core/context_provider_impl.o:(ContextProviderImpl::Create(fuchsia::web::CreateContextParams, fidl::InterfaceRequest<fuchsia::web::Context>))
    
    ld.lld: error: undefined symbol: gl::kGLImplementationStubName
    >>> referenced by context_provider_impl.cc:212 (../../fuchsia/engine/context_provider_impl.cc:212)
    >>>               obj/fuchsia/engine/web_engine_core/context_provider_impl.o:(ContextProviderImpl::Create(fuchsia::web::CreateContextParams, fidl::InterfaceRequest<fuchsia::web::Context>))
    clang: error: ld.lld command failed with exit code 1 (use -v to see invocation)
    [47037/47333] AR obj/components/password_manager/core/browser/libbrowser.a
    [47038/47333] AR obj/components/sync_sessions/libsync_sessions.a
    
    
    Original change's description:
    > [Fuchsia] Handle VULKAN feature flag in WebEngine
    > 
    > Now WebEngine will enable Vulkan only when ContextFeatureFlags::VULKAN
    > is specified for web::Context. Also Context process now explicitly
    > disables hardware-accelerated compositing when VULKAN is not enabled
    > (otherwise it restarts the GPU process several times before it falls
    > back to software compositing).
    > 
    > Bug: 962617, fuchsia:35009
    > Change-Id: I74a463a1514df99134d929981fe44151c1d9dd17
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774967
    > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    > Reviewed-by: Jonathan Backer <backer@chromium.org>
    > Reviewed-by: Wez <wez@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#691856}
    
    TBR=backer@chromium.org,wez@chromium.org,sergeyu@chromium.org
    
    Change-Id: I71d9bb87b79928bbffa9f123408b4e4bafad31bc
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 962617, fuchsia:35009
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775955Reviewed-by: default avatarTakashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#691941}
    e6aed4a9
BUILD.gn 8.4 KB