• Kevin Marshall's avatar
    Reland "Fix thread safety issues with safe browsing DB." · e6af5cab
    Kevin Marshall authored
    This is a reland of 0ac8d89e
    Original change's description:
    > Fix thread safety issues with safe browsing DB.
    > 
    > Fix thread safety issues with safe browsing DB.
    > The Safe Browsing DB has some sequence consistency issues, which
    > is caught by the stricter WeakPtr semantics detailed on CL 2908073007.
    > 
    > * Delete SafeBrowsingDatabaseManager on IO thread.
    > * Remove illegal dereferencing of IO-thread WeakPtr from DB thread in
    >   V4Database::VerifyChecksumOnTaskRunner
    > * Remove non-threadsafe accesses of |io_thread_| resident members from
    >   the DB thread in V4LocalDatabaseManager.
    > * Add IO-thread runloops to unit tests to handle database teardown.
    > 
    > 
    > R=nparker@chromium.org
    > CC=wez@chromium.org
    > 
    > Bug: 729716
    > Change-Id: I1bc620d42aca2f1cc99e482b7776a628d783d390
    > Reviewed-on: https://chromium-review.googlesource.com/523983
    > Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
    > Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Reviewed-by: Varun Khaneja <vakh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#481735}
    
    TBR=csharrison@chromium.org, grt@chromium.org, vakh@chromium.org
    
    Bug: 729716, 742596
    Change-Id: I4d67aa201c54be7a1e75a7375ac9861a29f1d87f
    Reviewed-on: https://chromium-review.googlesource.com/571684Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
    Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#486946}
    e6af5cab
v4_database.h 9.9 KB