• hiroshige's avatar
    Revert of add gn_all, gyp_all targets to build files, remove GN's //:root... · e6d374cf
    hiroshige authored
    Revert of add gn_all, gyp_all targets to build files, remove GN's //:root (patchset #18 id:350001 of https://codereview.chromium.org/936193004/)
    
    Reason for revert:
    Suspecting this breaks Mac builds.
    http://build.chromium.org/p/chromium/builders/Mac/builds/33993
    
    Original issue's description:
    > add gn_all, gyp_all targets to the build files, remove GN's //:root
    >
    > In order to be able to make sure we are building the same list of targets
    > in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all'
    > targets.
    >
    > Eventually, we should make sure that if one builds 'gn_all', then building
    > 'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this
    > is a start.
    >
    > The 'gn_all' target replaces the //:root target in the GN builds.
    >
    > R=brettw@chromium.org
    > BUG=461019
    > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
    >
    > Committed: https://crrev.com/ff30e3de333305ccdaa103aa7f9e46765da83e99
    > Cr-Commit-Position: refs/heads/master@{#317760}
    
    TBR=brettw@chromium.org,dpranke@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=461019
    
    Review URL: https://codereview.chromium.org/944573003
    
    Cr-Commit-Position: refs/heads/master@{#317763}
    e6d374cf
BUILD.gn 6.1 KB